Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Qt6 #1197

Closed
wants to merge 6 commits into from
Closed

Conversation

srmainwaring
Copy link

Add support for Qt6. This makes building on macOS (M1 and Intel) simpler as the default version of Qt distributed with brew is as of now Qt 6.7.

Marked as draft as the PR needs to be modified to make using Qt6 an option rather than a requirement. Posting as this may be useful to other mac users looking to run ROS 2 Rolling natively.

Tasks

  • enable Qt6 as an option
  • testing...

- Replace QRegExp with QRegularExpression
- Replace setMargin with setContentsMargins
- Add missing includes

Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
- Replace QRegExp with QRegularExpression

Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
@srmainwaring srmainwaring requested a review from ahcorde as a code owner May 10, 2024 15:59
@srmainwaring srmainwaring marked this pull request as draft May 10, 2024 15:59
@clalancette
Copy link
Contributor

Please see #1187 , where work has been ongoing to support both Qt5 and Qt6. I'm going to suggest that we actually close this in favor of that one, as it is relatively close to being able to work.

@srmainwaring
Copy link
Author

Please see #1187 , where work has been ongoing to support both Qt5 and Qt6. I'm going to suggest that we actually close this in favor of that one, as it is relatively close to being able to work.

Thanks @clalancette - missed that one as only searched issues. Ok happy to close this. Btw is there a similar effort underway for rqt as I have wip to support PySide6 / Shiboken6 but would be happy to pick up something nearly completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants