Remove use of python_cmake_module #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested review from
MichaelOrlov and
james-rms
and removed request for
a team
fujitatomoya
approved these changes
Feb 15, 2024
MichaelOrlov
approved these changes
Feb 16, 2024
|
I think in order for this to work on Windows Debug, we are also going to need ros2/ci#755 first. So let's hold off on merging this for now. |
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
0a88d5b
to
58f6675
Compare
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
58f6675
to
7892bac
Compare
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
7892bac
to
94acdcc
Compare
We really don't need it anymore, and can just use the builtin find_package(Python3). Signed-off-by: Chris Lalancette <[email protected]>
The comment in the commit explains the reasoning behind it. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
94acdcc
to
15eea04
Compare
|
CI for this (along with all of the rest of the changes needed) is in ros2/ros2#1524 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add in hints so that we find the unversioned python3 before finding versioned ones.
This must be merged before ros2/ros2#1524 ; see that pull request for more information about this change.