Skip to content

Commit

Permalink
Fix for rosbag2_transport::Recorder failures due to the unhandled exc…
Browse files Browse the repository at this point in the history
…eptions (#1382)

* Fix for rosbag2_transport::Recorder failures due to unhandled exceptions

Signed-off-by: Michael Orlov <[email protected]>

* Revert "Fix for rosbag2_transport::Recorder failures due to unhandled exceptions"

This reverts commit 767d440.

Signed-off-by: Michael Orlov <[email protected]>

* Handle exceptions in event publisher and discovery threads

- Exceptions potentially may come from the underlying node operations
when we are invalidating context via rclcpp::shutdown(). We need to have
possibility to correct finish recording in this case.

Signed-off-by: Michael Orlov <[email protected]>

---------

Signed-off-by: Michael Orlov <[email protected]>
(cherry picked from commit bb8d2a5)

# Conflicts:
#	rosbag2_transport/src/rosbag2_transport/recorder.cpp
  • Loading branch information
MichaelOrlov authored and mergify[bot] committed Jun 17, 2023
1 parent c3456fe commit 0b16482
Showing 1 changed file with 586 additions and 0 deletions.
Loading

0 comments on commit 0b16482

Please sign in to comment.