Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rosparam verb load #590

Merged
merged 5 commits into from
Feb 13, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions ros2param/ros2param/api/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,18 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from rcl_interfaces.msg import Parameter
from rcl_interfaces.msg import ParameterType
from rcl_interfaces.msg import ParameterValue
from rcl_interfaces.srv import DescribeParameters
from rcl_interfaces.srv import GetParameters
from rcl_interfaces.srv import ListParameters
from rcl_interfaces.srv import SetParameters
import rclpy
from rclpy.parameter import PARAMETER_SEPARATOR_STRING
from ros2cli.node.direct import DirectNode
import yaml
import sys


def get_value(*, parameter_value):
Expand Down Expand Up @@ -92,6 +95,46 @@ def get_parameter_value(*, string_value):
return value


def parse_parameter_dict(*, namespace, parameter_dict):
parameters = []
for param_name, param_value in parameter_dict.items():
full_param_name = namespace + param_name
# Unroll nested parameters
if type(param_value) == dict:
parameters += parse_parameter_dict(
namespace=full_param_name + PARAMETER_SEPARATOR_STRING,
parameter_dict=param_value)
else:
parameter = Parameter()
parameter.name = full_param_name
parameter.value = get_parameter_value(string_value=str(param_value))
parameters.append(parameter)
return parameters


def load_parameter_dict(*, node, node_name, parameter_dict):

parameters = parse_parameter_dict(namespace="", parameter_dict=parameter_dict)
response = call_set_parameters(
node=node, node_name=node_name, parameters=parameters)

# output response
assert len(response.results) == len(parameters)
for i in range(0, len(response.results)):
result = response.results[i]
param_name = parameters[i].name
if result.successful:
msg = 'Set parameter {} successful'.format(param_name)
if result.reason:
msg += ': ' + result.reason
print(msg)
else:
msg = 'Set parameter {} failed'.format(param_name)
if result.reason:
msg += ': ' + result.reason
print(msg, file=sys.stderr)


def call_describe_parameters(*, node, node_name, parameter_names=None):
# create client
client = node.create_client(
Expand Down
77 changes: 77 additions & 0 deletions ros2param/ros2param/verb/load.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
# Copyright 2021 Open Source Robotics Foundation, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from ros2cli.node.direct import DirectNode
from ros2cli.node.strategy import add_arguments
from ros2cli.node.strategy import NodeStrategy
from ros2node.api import get_absolute_node_name
from ros2node.api import get_node_names
from ros2node.api import NodeNameCompleter
from ros2param.api import load_parameter_dict
from ros2param.verb import VerbExtension

import yaml


class LoadVerb(VerbExtension):
"""Load parameter file for a node."""

def add_arguments(self, parser, cli_name): # noqa: D102
add_arguments(parser)
arg = parser.add_argument(
'node_name', help='Name of the ROS node')
arg.completer = NodeNameCompleter(
include_hidden_nodes_key='include_hidden_nodes')
parser.add_argument(
'--include-hidden-nodes', action='store_true',
help='Consider hidden nodes as well')
arg = parser.add_argument(
'parameter_file', help='Parameter file')
parser.add_argument(
'--use-wildcard', action='store_true',
help='Load parameters in the \'/**\' namespace into the node')

def main(self, *, args): # noqa: D102
with NodeStrategy(args) as node:
node_names = get_node_names(
node=node, include_hidden_nodes=args.include_hidden_nodes)

node_name = get_absolute_node_name(args.node_name)
if node_name not in {n.full_name for n in node_names}:
return 'Node not found'
# Remove leading slash
node_namespace = node_name[1:]

with DirectNode(args) as node:
with open(args.parameter_file, "r") as f:
param_file = yaml.safe_load(f)
param_namespaces = []
if args.use_wildcard and "/**" in param_file:
param_namespaces.append("/**")
if node_namespace in param_file:
param_namespaces.append(node_namespace)

if param_namespaces == []:
raise RuntimeError("Param file doesn't contain parameters for {}, "
" only for namespaces: {}" .format(node_namespace,
param_file.keys()))

for ns in param_namespaces:
value = param_file[ns]
if type(value) != dict or "ros__parameters" not in value:
raise RuntimeError("Invalid structure of parameter file in namespace {}"
"expected same format as provided by ros2 param dump"
.format(ns))
load_parameter_dict(node=node, node_name=node_name,
parameter_dict=value["ros__parameters"])
1 change: 1 addition & 0 deletions ros2param/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
'get = ros2param.verb.get:GetVerb',
'list = ros2param.verb.list:ListVerb',
'set = ros2param.verb.set:SetVerb',
'load = ros2param.verb.load:LoadVerb',
],
}
)