Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ROS Bosses to the list of distributions. #4879

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Add ROS Bosses to the list of distributions. #4879

merged 2 commits into from
Dec 2, 2024

Conversation

clalancette
Copy link
Contributor

As per the latest ROS 2 meeting.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Nov 26, 2024
@clalancette clalancette requested a review from audrow as a code owner November 26, 2024 20:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/12126068408/artifacts/2263344636.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4879/index.html in your favorite browser

fujitatomoya
fujitatomoya reviewed Dec 1, 2024
View reviewed changes
source/Releases.rst Outdated Show resolved Hide resolved
kscottz
kscottz approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@kscottz kscottz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions for Github handles for ROS bosses. Once those are accepted we're good to go.

source/Releases.rst Outdated Show resolved Hide resolved
source/Releases.rst Outdated Show resolved Hide resolved
source/Releases.rst Outdated Show resolved Hide resolved
source/Releases.rst Outdated Show resolved Hide resolved
source/Releases.rst Outdated Show resolved Hide resolved
source/Releases.rst Outdated Show resolved Hide resolved
source/Releases.rst Outdated Show resolved Hide resolved
source/Releases.rst Outdated Show resolved Hide resolved
source/Releases.rst Outdated Show resolved Hide resolved
source/Releases.rst Outdated Show resolved Hide resolved
@kscottz
Apply suggestions from code review
2167cc8 
Add Github profile to ROS Bosses. Fix spacing on shared bosses.

Signed-off-by: Katherine Scott <[email protected]>
@clalancette clalancette mentioned this pull request Dec 2, 2024
Open
@clalancette clalancette merged commit 707083c into rolling Dec 2, 2024
4 checks passed
@clalancette clalancette deleted the clalancette/ros-bosses branch December 2, 2024 22:04
mergify bot pushed a commit that referenced this pull request Dec 2, 2024
@clalancette @mergify
Add ROS Bosses to the list of distributions. (#4879)
442df56 
* Add ROS Bosses to the list of distributions.

Add Github profile to ROS Bosses. Fix spacing on shared bosses.

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Katherine Scott <[email protected]>
(cherry picked from commit 707083c)
@mergify mergify bot mentioned this pull request Dec 2, 2024
Merged
mergify bot pushed a commit that referenced this pull request Dec 2, 2024
@clalancette @mergify
Add ROS Bosses to the list of distributions. (#4879)
9650afc 
* Add ROS Bosses to the list of distributions.

Add Github profile to ROS Bosses. Fix spacing on shared bosses.

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Katherine Scott <[email protected]>
(cherry picked from commit 707083c)
mergify bot pushed a commit that referenced this pull request Dec 2, 2024
@clalancette @mergify
Add ROS Bosses to the list of distributions. (#4879)
35d4e87 
* Add ROS Bosses to the list of distributions.

Add Github profile to ROS Bosses. Fix spacing on shared bosses.

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Katherine Scott <[email protected]>
(cherry picked from commit 707083c)
This was referenced Dec 2, 2024
Merged
Merged
clalancette added a commit that referenced this pull request Dec 2, 2024
@mergify @clalancette
Add ROS Bosses to the list of distributions. (#4879) (#4887)
032e88c 
* Add ROS Bosses to the list of distributions.

Add Github profile to ROS Bosses. Fix spacing on shared bosses.

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Katherine Scott <[email protected]>
(cherry picked from commit 707083c)

Co-authored-by: Chris Lalancette <[email protected]>
clalancette added a commit that referenced this pull request Dec 2, 2024
@mergify @clalancette
Add ROS Bosses to the list of distributions. (#4879) (#4888)
c7185b6 
* Add ROS Bosses to the list of distributions.

Add Github profile to ROS Bosses. Fix spacing on shared bosses.

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Katherine Scott <[email protected]>
(cherry picked from commit 707083c)

Co-authored-by: Chris Lalancette <[email protected]>
clalancette added a commit that referenced this pull request Dec 2, 2024
@mergify @clalancette
Add ROS Bosses to the list of distributions. (#4879) (#4889)
773ccf1 
* Add ROS Bosses to the list of distributions.

Add Github profile to ROS Bosses. Fix spacing on shared bosses.

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Katherine Scott <[email protected]>
(cherry picked from commit 707083c)

Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@christophebedard christophebedard christophebedard left review comments

@kscottz kscottz kscottz approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clalancette @kscottz @christophebedard @fujitatomoya