Remove completely unnecessary use of CLASSNAME. (#471)

This test wasn't even being run with multiple rmw implementations, so just remove the unnecessary infrastructure. Signed-off-by: Chris Lalancette <[email protected]>
ros2 · Jul 8, 2024 · cf3e998 · cf3e998
1 parent f69abc1
commit cf3e998
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/test/benchmark/benchmark_logging.cpp b/test/benchmark/benchmark_logging.cpp
@@ -21,13 +21,6 @@
 #include "osrf_testing_tools_cpp/scope_exit.hpp"
 #include "rcutils/logging.h"
 
-#ifdef RMW_IMPLEMENTATION
-# define CLASSNAME_(NAME, SUFFIX) NAME ## __ ## SUFFIX
-# define CLASSNAME(NAME, SUFFIX) CLASSNAME_(NAME, SUFFIX)
-#else
-# define CLASSNAME(NAME, SUFFIX) NAME
-#endif
-
 size_t g_log_calls = 0;
 struct LogEvent
 {

diff --git a/test/test_allocator.cpp b/test/test_allocator.cpp
@@ -21,24 +21,17 @@
 #include "osrf_testing_tools_cpp/memory_tools/memory_tools.hpp"
 #include "osrf_testing_tools_cpp/scope_exit.hpp"
 
-#ifdef RMW_IMPLEMENTATION
-# define CLASSNAME_(NAME, SUFFIX) NAME ## __ ## SUFFIX
-# define CLASSNAME(NAME, SUFFIX) CLASSNAME_(NAME, SUFFIX)
-#else
-# define CLASSNAME(NAME, SUFFIX) NAME
-#endif
-
 using osrf_testing_tools_cpp::memory_tools::disable_monitoring_in_all_threads;
 using osrf_testing_tools_cpp::memory_tools::enable_monitoring_in_all_threads;
 using osrf_testing_tools_cpp::memory_tools::on_unexpected_calloc;
 using osrf_testing_tools_cpp::memory_tools::on_unexpected_free;
 using osrf_testing_tools_cpp::memory_tools::on_unexpected_malloc;
 using osrf_testing_tools_cpp::memory_tools::on_unexpected_realloc;
 
-class CLASSNAME (TestAllocatorFixture, RMW_IMPLEMENTATION) : public ::testing::Test
+class TestAllocatorFixture : public ::testing::Test
 {
 public:
-  CLASSNAME(TestAllocatorFixture, RMW_IMPLEMENTATION)() {}
+  TestAllocatorFixture() {}
 
   void SetUp()
   {
@@ -55,7 +48,8 @@ class CLASSNAME (TestAllocatorFixture, RMW_IMPLEMENTATION) : public ::testing::T
 
 /* Tests the default allocator.
  */
-TEST_F(CLASSNAME(TestAllocatorFixture, RMW_IMPLEMENTATION), test_default_allocator_normal) {
+TEST_F(TestAllocatorFixture, test_default_allocator_normal)
+{
   size_t mallocs = 0;
   size_t reallocs = 0;
   size_t callocs = 0;