Add Test Case for rclcpp_action Where the Status Message is Received Before the Service Response #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony <[email protected]>
tony-laza
force-pushed
the
tony-laza/receive_status_before_service_response
branch
from
c103966 to
cb28826
Compare
Comment on lines
+456
to
+457
| // Spin until the client receives the goal | ||
| dual_spin_until_future_complete(future_goal_handle); |
There was a problem hiding this comment.
in this particular case, i believe that GoalResponse(accepted) and Status messages are already in the rmw implementation, and the question here is which should be taken 1st. currently, the order to take the action entities is feedback, status, goal_response, result_response and cancel_response. so that status is going to be taken and processed before goal_response.
but this order only matters when the messages are already in the queue of rmw implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases to the
rclcpp_actionclients where theExecutingstatus response is received before the service callback. The test leverages a specific sequence ofspin()invocation on the executors, however, it is possible to reproduce this non-deterministically in other cases. A forthcoming issue ticket will give more details.