Revert "Add support for spin_until_timeout (#1821)" #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
This looks good to me once the Rpr job comes back green.
I'm happy with just the Rpr job because nothing else was merged since #1951 a couple of days ago, so we have pretty good confidence in that.
The only other thing I'll request when merging this is that we open a "Revert Revert" PR so we can get that ready to go once the dependent PRs are ready.
wjwwood
added a commit
that referenced
this pull request
Jun 24, 2022
This was referenced Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1874
See the reason here: #1874 (comment)