MessageFilter Generalizated Nodes

[CursedRock17]

This PR should entirely resolve #95 as pull request #96 didn't use a templated Node in the MessageFilter constructors. There were concerns of:

Retain[ing] the existing node-based interface for backwards compatibility.

which we can do with defaulted templated Nodes and node_interface methods.

[ahcorde]

@clalancette what do you think about this?

which we can do with defaulted templated Nodes and node_interface methods.

I can see both strategies in some other packages, any recomendation ?

[ahcorde]

conflicts

[sloretz]

@CursedRock17 friendly ping to rebase the PR 🧇

[CursedRock17]

@sloretz after I saw issue #698, I began writing a fix which would essentially make this PR obsolete. Is it even still worth cleaning up and merging this in, if it's going to be deprecated in the future, I would feel it to be a dead feature.

[clalancette]

@sloretz after I saw issue #698, I began writing a fix which would essentially make this PR obsolete. Is it even still worth cleaning up and merging this in, if it's going to be deprecated in the future, I would feel it to be a dead feature.

Agreed with your reasoning. In that case, I'm going to close this out. But feel free to reopen if you think we should pursue this.