Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme to point to http://aka.ms/ros/mrtk for Hololens support #113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hoffmann-stefan
Copy link
Member

@ooeygui pointed out that the current codebase for using ROS 2 on Hololens is over at http://aka.ms/ros/mrtk_native and http://aka.ms/ros/mrtk, see comment #109 (comment)

After looking at it seems the tooling and install instructions over there are way better and more up to date.
Instead of having some duplicate install and setup instructions for UWP/Hololens in the README, we should simply point to the ros_msft_mrtk repo.

The current codebase for Hololens support is over there.
The installation and usage instructions are more streamlined there as well.
When enabling the CI for UWP again one might look at the more up to date ones from http://aka.ms/ros/mrtk_native.
@hoffmann-stefan hoffmann-stefan changed the title Update readme mrtk Update Readme to point to http://aka.ms/ros/mrtk for Hololens support Jun 4, 2023
@esteve
Copy link
Member

esteve commented Jun 5, 2023

@hoffmann-stefan I'd prefer if the references to ros2-dotnet supporting UWP were not removed, I worked quite hard to make sure that all the components in ROS 2 supported UWP (i.e. FastRTPS/FastDDS, rmw, rcl, ros2-dotnet, etc.)

@ooeygui could you clarify what was missing in this repository to support UWP? I asked you in #82 (comment) because five years ago we already demoed ros2-dotnet running onboard the Hololens 1, and did all the work to port ROS 2 and ros2-dotnet to UWP

@esteve
Copy link
Member

esteve commented Jun 5, 2023

@hoffmann-stefan for reference, this is the talk I gave at ROSCon in 2018 about adding support for UWP to ROS 2 ROS2 for Android, iOS and Universal Windows Platform

@hoffmann-stefan
Copy link
Member Author

@esteve I added a section to the README.md that should better explain the UWP support and how this library contributes to this. The point of this PR is to point to the tooling and install instructions of the Mixed Reality Toolkit for ROS 2, not to remove the references to the UWP support.

Does this address your concerns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants