Skip to content

Commit d7b7be3

Browse files
committed
Fix flaky multipleClients test
Sleep is required especially on many-core environment.
1 parent e9f8fa8 commit d7b7be3

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

test/test_client.cpp

+10-6
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,20 @@ TEST(dynamic_reconfigure_simple_client, setGetConfig) {
121121
}
122122

123123
TEST(dynamic_reconfigure_simple_client, multipleClients) {
124-
Client<TestConfig> client1("/ref_server", &configurationCallback);
125-
Client<TestConfig> client2("/ref_server", &configurationCallback);
126-
Client<TestConfig> client3("/ref_server", &configurationCallback);
127-
client3.setConfiguration(TestConfig::__getDefault__());
124+
Client<TestConfig> client1("/ref_server", &configurationCallback,
125+
&descriptionCallback);
126+
Client<TestConfig> client2("/ref_server", &configurationCallback,
127+
&descriptionCallback);
128+
Client<TestConfig> client3("/ref_server", &configurationCallback,
129+
&descriptionCallback);
130+
ros::Duration(0.2).sleep();
131+
EXPECT_TRUE(client3.setConfiguration(TestConfig::__getDefault__()));
128132
ros::Duration(0.2).sleep();
129133
EXPECT_EQ(0, CONFIG.int_);
130-
client1.setConfiguration(TestConfig::__getMin__());
134+
EXPECT_TRUE(client1.setConfiguration(TestConfig::__getMin__()));
131135
ros::Duration(0.2).sleep();
132136
EXPECT_EQ(-10, CONFIG.int_);
133-
client2.setConfiguration(TestConfig::__getMax__());
137+
EXPECT_TRUE(client2.setConfiguration(TestConfig::__getMax__()));
134138
ros::Duration(0.2).sleep();
135139
EXPECT_EQ(10, CONFIG.int_);
136140
}

0 commit comments

Comments
 (0)