Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the resizing by dragging of the render window of the image dispalay plugin #1619

Open
wants to merge 13 commits into
base: melodic-devel
Choose a base branch
from

Conversation

HankWong-guangdong
Copy link

@HankWong-guangdong HankWong-guangdong commented Apr 12, 2021

Description

Make resizing the render window in image_display by dragging on the left bottom corner and the right bottom corner to be as easy as resizing by dragging on the left top corner and the right top corner.

Checklist

image

@rhaschke
Copy link
Contributor

Thanks for providing this PR. Could you please update the PR title to something meaningful, i.e. reflecting the actual problem being solved? Also, please remove irrelevant items from the checklist in the main PR description.

@rhaschke rhaschke marked this pull request as draft April 12, 2021 13:26
@rhaschke
Copy link
Contributor

I changed this to draft as you seem to still be working on it. Please mark as "ready for review" if it is. Thanks.

@rhaschke
Copy link
Contributor

You might want to install pre-commit as a git pre-commit hook to automatically perform formatting checks:

pip install pre-commit
pre-commit install

@HankWong-guangdong HankWong-guangdong changed the title Patch 1 Improving the resizing of the render window of the image dispalay plugin Apr 12, 2021
@HankWong-guangdong HankWong-guangdong changed the title Improving the resizing of the render window of the image dispalay plugin Improving the resizing by dragging of the render window of the image dispalay plugin Apr 12, 2021
@HankWong-guangdong HankWong-guangdong marked this pull request as ready for review April 12, 2021 13:48
@HankWong-guangdong
Copy link
Author

Thanks for providing this PR. Could you please update the PR title to something meaningful, i.e. reflecting the actual problem being solved? Also, please remove irrelevant items from the checklist in the main PR description.

Hello!I want to ask what you think about the PR. Would the PR be merged?

@rhaschke
Copy link
Contributor

Sorry, I didn't have time to look into this PR yet. I'm maintaining rviz on a voluntary basis in my free time!

@HankWong-guangdong
Copy link
Author

Sorry, I didn't have time to look into this PR yet. I'm maintaining rviz on a voluntary basis in my free time!

It doesn’t matter. Please consider the PR when you have time. Thank you!

@rhaschke
Copy link
Contributor

I tried your PR and couldn't notice any difference regarding panel resizing.

@rhaschke
Copy link
Contributor

@HankWong-guangdong, could you please clarify what should have changed by this PR? I don't notice any change in behavior.

@HankWong-guangdong
Copy link
Author

@HankWong-guangdong, could you please clarify what should have changed by this PR? I don't notice any change in behavior.

I found that the improvement for the panel resizing is little,I want to continue to improve the panel resizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants