-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the resizing by dragging of the render window of the image dispalay plugin #1619
base: melodic-devel
Are you sure you want to change the base?
Improving the resizing by dragging of the render window of the image dispalay plugin #1619
Conversation
The render window for image display plugin
not only for the image display plugin
Thanks for providing this PR. Could you please update the PR title to something meaningful, i.e. reflecting the actual problem being solved? Also, please remove irrelevant items from the checklist in the main PR description. |
I changed this to draft as you seem to still be working on it. Please mark as "ready for review" if it is. Thanks. |
You might want to install pre-commit as a git pre-commit hook to automatically perform formatting checks: pip install pre-commit
pre-commit install |
Hello!I want to ask what you think about the PR. Would the PR be merged? |
Sorry, I didn't have time to look into this PR yet. I'm maintaining |
It doesn’t matter. Please consider the PR when you have time. Thank you! |
I tried your PR and couldn't notice any difference regarding panel resizing. |
@HankWong-guangdong, could you please clarify what should have changed by this PR? I don't notice any change in behavior. |
I found that the improvement for the panel resizing is little,I want to continue to improve the panel resizing. |
Description
Make resizing the render window in image_display by dragging on the left bottom corner and the right bottom corner to be as easy as resizing by dragging on the left top corner and the right top corner.
Checklist