Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add label point cloud transformer #1162

Open
wants to merge 1 commit into
base: kinetic-devel
Choose a base branch
from
Open

add label point cloud transformer #1162

wants to merge 1 commit into from

Conversation

daizr
Copy link

@daizr daizr commented Oct 10, 2017

@dhood
Copy link
Contributor

dhood commented Dec 19, 2017

I haven't reviewed the code in great detail yet, but have tested it out as a user. One of the issues I've encountered is that if I want to swap label colours for, say, 3 and 5, then as soon I modify 5's LabelProperty to refer to label ID 3, if a point cloud comes in with 5 in it, it will add another LabelProperty for label ID 5 at the end of the list (since it ensures that one exists for 5 at all times). I continue with my swap of 3 and 5 and am then left wondering which of the two LabelProperty's for ID 5 actually applies. This duplication even happens if I go to edit the label ID for 5's LabelProperty and then back out: I end up with two LabelProperty's for 5.

What do you think about having the label ID as immutable? This will solve the above problem, but will be inconvenient for users that have set up their LabelProperty's by alias and want to swap label IDs, e.g. because for one reason or another the point cloud labels get shuffled. In that case the user could still edit the rviz config file, swapping the label IDs for LabelProperty's.

@dhood dhood added this to the untargeted milestone Dec 19, 2017
@dhood dhood self-assigned this Apr 7, 2018
@wjwwood wjwwood removed this from the untargeted milestone May 10, 2018
130s pushed a commit to 130s/rviz that referenced this pull request Aug 21, 2024
…ization#1162)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 92023c966414d4d9a044ad8f609a1c6f3ca402d3)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants