Replace deprecated spin_until_future_complete
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to RCLCPP API change ros2/rclcpp#1874. |
hliberacki
force-pushed
the
hliberacki/spin_until
branch
from
dafb266
to
1247fb1
Compare
|
ros2/rclcpp#1874 (comment) Passing CI with all related PRs linked and build together. |
…lete` Signed-off-by: Hubert Liberacki <[email protected]>
hliberacki
force-pushed
the
hliberacki/spin_until
branch
from
1247fb1
to
e37fd69
Compare
We're about to create a 'rolling' branch for this repository anyway (early next week), so we'll retarget it then. |
fujitatomoya
approved these changes
Jul 19, 2022
|
This PR is not required anymore due to changes in #126. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated
spin_until_future_completewithspin_until_completeSigned-off-by: Hubert Liberacki [email protected]