Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows compilation in image_publisher.cpp (backport #1061) #1062

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 6, 2025

PR #985 added some code that used M_PI, but M_PI is not defined in any standard, and before including cmath or math.h in Windows it is necessary to define _USE_MATH_DEFINES to ensure that M_PI is defined.


This is an automatic backport of pull request #1061 done by Mergify.

PR #985 added some
code that used `M_PI`, but `M_PI` is not defined in any standard, and
before including `cmath` or `math.h` in Windows it is necessary to
define `_USE_MATH_DEFINES` to ensure that `M_PI` is defined.

(cherry picked from commit 86f51ab)
@ahcorde ahcorde merged commit c3baf0d into jazzy Jan 6, 2025
2 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-1061 branch January 6, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants