image_publisher: Fix image, constantly flipping when static image is …

…published (backport #986) (#988)

Continuation of
#984.

When publishing video stream from a camera, the image was flipped
correctly. Yet for a static image, which was loaded once, the flip
function was applied every time `ImagePublisher::doWork()` was called,
resulting in the published image being flipped back and forth all the
time.

This PR should be straightforward to port it to `Humble`, `Iron` and
`Jazzy`.<hr>This is an automatic backport of pull request #986 done by
[Mergify](https://mergify.com).

Co-authored-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>

image_publisher/include/image_publisher/image_publisher.hpp

@@ -65,6 +65,7 @@ class ImagePublisher : public rclcpp::Node
   std::string filename_;
   bool flip_horizontal_;
   bool flip_vertical_;
+  bool image_flipped_;
   bool retry_;  // If enabled will retry loading image from the filename_
   int timeout_;  // Time after which retrying starts
 

image_publisher/src/image_publisher.cpp

@@ -137,9 +137,11 @@ void ImagePublisher::doWork()
       if (!cap_.read(image_)) {
         cap_.set(cv::CAP_PROP_POS_FRAMES, 0);
       }
+      image_flipped_ = false;
     }
-    if (flip_image_) {
+    if (flip_image_ && !image_flipped_) {
       cv::flip(image_, image_, flip_value_);
+      image_flipped_ = true;
     }
 
     sensor_msgs::msg::Image::SharedPtr out_img =
@@ -206,6 +208,7 @@ void ImagePublisher::onInit()
   } else {
     flip_image_ = false;
   }
+  image_flipped_ = false;  // Image newly read, needs to be flipped
 
   camera_info_.width = image_.cols;
   camera_info_.height = image_.rows;