Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add detectron2 detector #17

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

tony23545
Copy link
Collaborator

No description provided.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small things

detectron2_detector/README.md Outdated Show resolved Hide resolved
detectron2_detector/README.md Outdated Show resolved Hide resolved
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last little thing - though I'd like to get running on the Jetson before merging this and update it with anything required to make that work

detectron_score_thresh: 0.8
# processing parameters
pointcloud2_topic: "/camera/depth/points"
categories: [0] # please check out COCO dataset category_id list if you want to config this; if you want to track all, leave it empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this by line number in the COCO file or by string? If by line #, mention that in the readme. That's probably obvious to AI engineers but probably not for robotics engineers

@SteveMacenski
Copy link
Member

@tony23545 any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants