Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BASE_IMAGE argument to fix rolling nightly builds #8

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CihatAltiparmak
Copy link
Contributor

@CihatAltiparmak CihatAltiparmak commented Jan 27, 2025

Rolling nightly builds uses osrf/ros-rolling-desktop-full docker image at where ROS2 is installed from apt. I have a case which I have encountered. In this case, geometry msgs was in testing phase, so I had to build geometry msgs locally.

Screenshot from 2025-01-28 02-13-27

@CihatAltiparmak CihatAltiparmak force-pushed the fix/build_rolling_image_from_testing_repo branch from 27bce4e to 9dd46f4 Compare January 27, 2025 23:53
@SteveMacenski
Copy link
Member

Let me know if/when you want me to review

@CihatAltiparmak
Copy link
Contributor Author

Btw updated my comment in order to show the mistake. I will test it in my other account. Bc it is not easy to test github workflow.

@SteveMacenski
Copy link
Member

We have a version of geometry_msgs in Nav2's underlay that builds from source due to adding in a new message definition not yet in Rolling binaries. The nightly's for rolling are building correctly (https://github.com/ros-navigation/nav2_docker/actions/runs/12983823889/job/36205693741), so I wonder if your issue is that this needs to be rebased / pull in recent changes that fixed the docker builds to pull in Nav2's underlay during building. Else, if up to date, this may involve some kind of regression, but I don't see how that's possible (so I'm putting my money that you need to pull in the recent changes the past several weeks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants