Handle virtual deb packages when querying apt cache #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since CI is still a mess, I confirmed this locally using a |
nuclearsandwich
approved these changes
Mar 8, 2024
These virtual packages are supported by the rosdep tool, so should be acceptable for use here as well.
cottsay
force-pushed
the
cottsay/deb-provides-cache
branch
from
232e10a
to
4e0189e
Compare
|
For the sake of incremental progress, I modified the code to resolve the virtual package only if there is a single package providing it. This doesn't encompass the entire virtual package scenario that the rosdep tool can handle, but should cover the more critical use cases without introducing any opportunity for nondeterminism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These virtual packages are supported by the rosdep tool, so should be acceptable for use here as well.