Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error message for unknown ROS distributions. #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

clalancette
Copy link
Contributor

This adds a 404 for unknown ROS distributions rather than a
page that just doesn't work.

Fixes #22

Signed-off-by: Chris Lalancette [email protected]

This adds a 404 for unknown ROS distributions rather than a
page that just doesn't work.

Signed-off-by: Chris Lalancette <[email protected]>
@mikaelarguedas
Copy link
Contributor

While we don;t ship dry distros anymore, this is specific to wet distros making it impossible to have dry_distros on the prerelease website if someone wants right ?

@clalancette
Copy link
Contributor Author

While we don;t ship dry distros anymore, this is specific to wet distros making it impossible to have dry_distros on the prerelease website if someone wants right ?

I guess that is true; a dry distro would run afoul of the initial check and then just throw a 404. But as you say, we don't have any dry distros anymore, so it's not really something I could test. Should we just remove the code for dry distros?

@tfoote
Copy link
Member

tfoote commented May 21, 2018

Should we just remove the code for dry distros?
I'd say yes to removing support for dry distros. We only support rosbuild based things from source in a workspace now and we don't intend to bring it back and don't expect anyone else to use it so clearing it makes sense.

We no longer need to do prerelease for dry distros, so just
remove that class and the one user.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

I'd say yes to removing support for dry distros. We only support rosbuild based things from source in a workspace now and we don't intend to bring it back and don't expect anyone else to use it so clearing it makes sense.

Thanks. Done in b62288e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants