Add timeouts #220
Merged
Add timeouts #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellantos
reviewed
Nov 22, 2023
| @@ -111,6 +111,7 @@ but come from the lely core library. Below you find a list of possible configura | |||
| reset_all_nodes; Specifies whether all slaves shall be reset in case of an error event on a mandatory slave (default: false, see bit 4 in object 1F80). | |||
| stop_all_nodes; Specifies whether all slaves shall be stopped in case of an error event on a mandatory slave (default: false, see bit 6 in object 1F80). | |||
| boot_time; The timeout for booting mandatory slaves in ms (default: 0, see object 1F89). | |||
| boot_timeout; The timeout for booting all slaves in ms (default: 100ms). | |||
There was a problem hiding this comment.
100ms seems very short fot a default. I would say go with something like 2 seconds.
| { | ||
| RCLCPP_WARN( | ||
| this->node_->get_logger(), | ||
| "No timeout parameter found in config file. Using default value of 100ms."); |
There was a problem hiding this comment.
Change to boot timeout, otherwise it is hard to get.
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: