Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for automatic setup of GitLab CI credentials #594

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Initial support for automatic setup of GitLab CI credentials #594

wants to merge 4 commits into from

Conversation

stertingen
Copy link
Contributor

@stertingen stertingen commented Jan 25, 2021

Slightly over-engineered alternative to

variables:
  AFTER_INIT_EMBED: "git config --global url.${CI_SERVER_PROTOCOL}://gitlab-ci-token:${CI_JOB_TOKEN}@${CI_SERVER_HOST}:${CI_SERVER_PORT}.insteadOf ${CI_SERVER_URL}"

@mathias-luedtke
Copy link
Member

While it might not be necessary for Gitlab CI, such a credential helper might be good for Github access tokens.

@mathias-luedtke
Copy link
Member

With #613, we could just prepare .gitconfig and .gitcredentials outside of the industrial_ci run (e.g. from gitlab.sh) and then just copy the credentials.
I don't think that passing the token as an environment variable is more secure than storing it in a file (in the context of CI tests!).

If we automate this in the CI-specific entry point, then it still works with run_ci..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants