-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set C++11 compile flag #19
base: master
Are you sure you want to change the base?
Conversation
Can you provide a bit of context? C++11 is not used in this package (yet, iirc), so that flag would seem to be unnecessary. If you need it for some downstream package, I would suggest to set it there. |
I tried to compile it on aarch64 platform with Linux for Tegra When I tried to compile Poco installation based on ppa build failed as
Then I compiled current stable version of Poco poco-1.9.0-release from source. This version requires C++11 std. Thus when linking with Poco, without C++11 I envounter following error
And thus to link with Poco current stable release proposing to set standard to C++11. Also check POCO 2.0 goals |
@sriharshav wrote:
That is not a platform that we currently explicitly target with this library, so please be prepared to encounter some issues.
Which is not surprising, as that PPA only builds for
We currently only test against Poco If Poco requires C++11, it should set that and export that setting. I'd rather see whether the Poco CMake infrastructure exports something like that than hard-coding the flag in our build script. Could you check whether that is the case? |
That wasn't evident from
And about Poco exporting C++11
Agree that hard-coding a flag to meet downstream requirements is not a good practice. |
I'm not against fixing up our side of the |
No description provided.