ci: re-enable Foxy builds

[gavanderhoorn]

As per subject.

This PR is a test, to see if this will (still) build.

[gavanderhoorn]

I'm wondering whether we should disable the ros-testing builds.

abb_librws is not a ROS package, so we're not actually linking against anything from ROS. Including ros-testing builds does not seem to add much in terms of CI, as it just reruns the build on the same OS, but with a different ROS package repository (which we don't use).

I'm tempted to remove the them as part of this PR.

@jontje?

[jontje]

I think it would be reasonable to remove them.

[Levi-Armstrong]

The only thing I have ran into is some distros release newer version of system dependencies which may have changes in the API. The example I am thinking of is FCL where on Noetic it release a new version 0.6.0 where on foxy they have not so you end up using the system version which is 0.5.0 for 20.04. This may be a rare case but thought I would mention.

[gavanderhoorn]

@Levi-Armstrong wrote:

The only thing I have ran into is some distros release newer version of system dependencies which may have changes in the API. The example I am thinking of is FCL where on Noetic it release a new version 0.6.0 where on foxy they have not so you end up using the system version which is 0.5.0 for 20.04. This may be a rare case but thought I would mention.

This is certainly something to keep in mind.

The question here was whether building against ros-testing would get us anything which the base ros repositories would not cover. Seeing as they are all built on the same OS (Melodic on Bionic, Noetic on Focal, ROS 2 on Focal), regardless of whether it's the testing repository or not, and we only have a single system-dependency here which doesn't change between the main and the testing repositories, I believe we'd be safe disabling those testing builds.