Add CI job to test compilation on Windows with vcpkg #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gavanderhoorn I should have addressed all the comments and cleanup the commit history. |
gavanderhoorn
approved these changes
Jun 2, 2020
|
I'm assuming we can duplicate this for Or would the Poco dependency be difficult to set up? |
Fortunately |
|
Nice work! 😄 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #92 .
The problems discussed #92 were actually just due to a wrong order of arguments passed to CMake (
cmake --config Release --build .seems to ignore the--buildflag).The correct compilation was tested in traversaro#2 .
The CI uses https://github.com/marketplace/actions/run-vcpkg to cache the installation of vcpkg dependencies, ensuring that the build on the master branch (after the first one, that is used to populate the cache) do not take ~20 minutes.