Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libphidget22 1.19 #175

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

mintar
Copy link
Contributor

@mintar mintar commented Mar 11, 2024

This version of libphidget22 compiles without warnings, so we don't need the patch file any more.

This version of libphidget22 compiles without warnings, so we don't need
the patch file any more.
@mintar
Copy link
Contributor Author

mintar commented Mar 11, 2024

@clalancette : What do you think about this PR? Upgrading the libphidget22 from time to time is necessary to support new devices.

If you agree to this PR, I'll open another one for the ROS2 branches (humble, iron + rolling).

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, totally on-board with updating this.

@mintar mintar merged commit f298048 into ros-drivers:noetic Mar 13, 2024
2 checks passed
@mintar mintar deleted the update-libphidget-1.19-noetic branch March 13, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants