GigE cameras - allow IP configuration and GigE-specific parameters configuration #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a launch file camera_gige.launch, to allow IP address and subnet configuration for GigE cameras.
Also, a few parameters specific to GigE cameras can be tuned :
The new launch file provides default values for these parameters, if you intend to use them, the parameter enable_gige_parameters has to be set to True, otherwise the values will be ignored.
This was tested with a GigE BlackFly S camera only.
Finally, when using several GigE cameras, the IP configuration somehow fails sometimes, and applies to the wrong camera. I couldn't find a way to fix this issue. So, the code as it is should be used to configure the IP while a single camera is connected, and use default parameters to avoid modifying the IP configuration when several cameras are connected.