Skip to content

Branch for Jazzy #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/humble-source-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,4 @@ jobs:
with:
ros_distro: humble
ref: humble
ros2_repo_branch: humble
os_name: ubuntu-22.04
4 changes: 2 additions & 2 deletions .github/workflows/jazzy-abi-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_dispatch:
pull_request:
branches:
- master
- jazzy
paths:
- '**.hpp'
- '**.h'
Expand All @@ -16,7 +16,7 @@ on:
- '**.xml'

concurrency:
# cancel previous runs of the same workflow, except for pushes on master branch
# cancel previous runs of the same workflow, except for pushes on jazzy branch
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ !startsWith(github.ref, '/refs/heads') }}

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/jazzy-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
workflow_dispatch:
pull_request:
branches:
- master
- jazzy
- '*feature*'
- '*feature/**'
paths:
Expand All @@ -22,7 +22,7 @@ on:
- '**.xml'
push:
branches:
- master
- jazzy
paths:
- '**.hpp'
- '**.h'
Expand All @@ -38,7 +38,7 @@ on:
- cron: '03 1 * * *'

concurrency:
# cancel previous runs of the same workflow, except for pushes on master branch
# cancel previous runs of the same workflow, except for pushes on jazzy branch
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ !startsWith(github.ref, '/refs/heads') }}

Expand All @@ -53,4 +53,4 @@ jobs:
ros_distro: jazzy
ros_repo: ${{ matrix.ROS_REPO }}
upstream_workspace: ros2_controllers-not-released.jazzy.repos
ref_for_scheduled_build: master
ref_for_scheduled_build: jazzy
2 changes: 1 addition & 1 deletion .github/workflows/jazzy-check-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
pull_request:
branches:
- master
- jazzy
paths:
- '**.rst'
- '**.md'
Expand Down
63 changes: 31 additions & 32 deletions .github/workflows/jazzy-coverage-build.yml
Original file line number Diff line number Diff line change
@@ -1,40 +1,39 @@
name: Coverage Build - Jazzy
on:
workflow_dispatch:
# TODO(anyone) activate when branched for Jazzy
# push:
# branches:
# - master
# paths:
# - '**.hpp'
# - '**.h'
# - '**.cpp'
# - '.github/workflows/jazzy-coverage-build.yml'
# - '**.yaml'
# - '**/package.xml'
# - '**/CMakeLists.txt'
# - 'codecov.yml'
# - '**/package.xml'
# - '**/CMakeLists.txt'
# - 'ros2_controllers.jazzy.repos'
# pull_request:
# branches:
# - master
# paths:
# - '**.hpp'
# - '**.h'
# - '**.cpp'
# - '.github/workflows/jazzy-coverage-build.yml'
# - '**.yaml'
# - '**/package.xml'
# - '**/CMakeLists.txt'
# - 'codecov.yml'
# - '**/package.xml'
# - '**/CMakeLists.txt'
# - 'ros2_controllers.jazzy.repos'
push:
branches:
- jazzy
paths:
- '**.hpp'
- '**.h'
- '**.cpp'
- '.github/workflows/jazzy-coverage-build.yml'
- '**.yaml'
- '**/package.xml'
- '**/CMakeLists.txt'
- 'codecov.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- 'ros2_controllers.jazzy.repos'
pull_request:
branches:
- jazzy
paths:
- '**.hpp'
- '**.h'
- '**.cpp'
- '.github/workflows/jazzy-coverage-build.yml'
- '**.yaml'
- '**/package.xml'
- '**/CMakeLists.txt'
- 'codecov.yml'
- '**/package.xml'
- '**/CMakeLists.txt'
- 'ros2_controllers.jazzy.repos'

concurrency:
# cancel previous runs of the same workflow, except for pushes on master branch
# cancel previous runs of the same workflow, except for pushes on jazzy branch
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ !startsWith(github.ref, '/refs/heads') }}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/jazzy-debian-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_dispatch:
pull_request:
branches:
- master
- jazzy
paths:
- '**.hpp'
- '**.h'
Expand All @@ -20,7 +20,7 @@ on:
- cron: '03 1 * * *'

concurrency:
# cancel previous runs of the same workflow, except for pushes on master branch
# cancel previous runs of the same workflow, except for pushes on jazzy branch
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ !startsWith(github.ref, '/refs/heads') }}

Expand All @@ -31,5 +31,5 @@ jobs:
with:
ros_distro: jazzy
upstream_workspace: ros2_controllers.jazzy.repos
ref_for_scheduled_build: master
ref_for_scheduled_build: jazzy
skip_packages: rqt_joint_trajectory_controller
2 changes: 1 addition & 1 deletion .github/workflows/jazzy-pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
pull_request:
branches:
- master
- jazzy

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/jazzy-rhel-semi-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_dispatch:
pull_request:
branches:
- master
- jazzy
paths:
- '**.hpp'
- '**.h'
Expand All @@ -20,7 +20,7 @@ on:
- cron: '03 1 * * *'

concurrency:
# cancel previous runs of the same workflow, except for pushes on master branch
# cancel previous runs of the same workflow, except for pushes on jazzy branch
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ !startsWith(github.ref, '/refs/heads') }}

Expand All @@ -30,5 +30,5 @@ jobs:
with:
ros_distro: jazzy
upstream_workspace: ros2_controllers.jazzy.repos
ref_for_scheduled_build: master
ref_for_scheduled_build: jazzy
skip_packages: rqt_joint_trajectory_controller
10 changes: 5 additions & 5 deletions .github/workflows/jazzy-semi-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
workflow_dispatch:
pull_request:
branches:
- master
- jazzy
- '*feature*'
- '*feature/**'
paths:
Expand All @@ -21,7 +21,7 @@ on:
- '**.xml'
push:
branches:
- master
- jazzy
paths:
- '**.hpp'
- '**.h'
Expand All @@ -38,7 +38,7 @@ on:
- cron: '33 1 * * *'

concurrency:
# cancel previous runs of the same workflow, except for pushes on master branch
# cancel previous runs of the same workflow, except for pushes on jazzy branch
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ !startsWith(github.ref, '/refs/heads') }}

Expand All @@ -49,14 +49,14 @@ jobs:
ros_distro: jazzy
ros_repo: testing
upstream_workspace: ros2_controllers.jazzy.repos
ref_for_scheduled_build: master
ref_for_scheduled_build: jazzy
semi_binary_clang:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
with:
ros_distro: jazzy
ros_repo: testing
upstream_workspace: ros2_controllers.jazzy.repos
ref_for_scheduled_build: master
ref_for_scheduled_build: jazzy
additional_debs: clang
c_compiler: clang
cxx_compiler: clang++
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/jazzy-semi-binary-downstream-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
workflow_dispatch:
pull_request:
branches:
- master
- jazzy
paths:
- '**.hpp'
- '**.h'
Expand All @@ -29,7 +29,7 @@ jobs:
with:
ros_distro: jazzy
ros_repo: testing
ref_for_scheduled_build: master
ref_for_scheduled_build: jazzy
upstream_workspace: ros2_controllers.jazzy.repos
# we don't test this repository, we just build it
not_test_build: true
Expand All @@ -41,7 +41,7 @@ jobs:
with:
ros_distro: jazzy
ros_repo: testing
ref_for_scheduled_build: master
ref_for_scheduled_build: jazzy
upstream_workspace: ros2_controllers.jazzy.repos
# we don't test this repository, we just build it
not_test_build: true
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/jazzy-source-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_dispatch:
push:
branches:
- master
- jazzy
paths:
- '**.hpp'
- '**.h'
Expand All @@ -24,6 +24,5 @@ jobs:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-source-build.yml@master
with:
ros_distro: jazzy
ref: master
ros2_repo_branch: jazzy
ref: jazzy
container: ubuntu:24.04
1 change: 0 additions & 1 deletion .github/workflows/rolling-source-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,4 @@ jobs:
with:
ros_distro: rolling
ref: master
ros2_repo_branch: rolling
container: ubuntu:24.04
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ If you are new to the project, please read the [contributing guide](https://cont

ROS2 Distro | Branch | Build status | Documentation | Released packages
:---------: | :----: | :----------: | :-----------: | :---------------:
**Rolling** | [`master`](https://github.com/ros-controls/ros2_controllers/tree/master) | [![Rolling Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-binary-build.yml?branch=master) <br> [![Rolling Semi-Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-semi-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-semi-binary-build.yml?branch=master) <br> [![build.ros2.org](https://build.ros2.org/buildStatus/icon?job=Rdev__ros2_controllers__ubuntu_noble_amd64&subject=build.ros2.org)](https://build.ros2.org/job/Rdev__ros2_controllers__ubuntu_noble_amd64/) | [control.ros.org](https://control.ros.org/master/doc/ros2_controllers/doc/controllers_index.html) | [ros2_controllers](https://index.ros.org/p/ros2_controllers/#rolling)
**Jazzy** | [`master`](https://github.com/ros-controls/ros2_controllers/tree/master) | [![Jazzy Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/jazzy-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/jazzy-binary-build.yml?branch=master) <br> [![Jazzy Semi-Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/jazzy-semi-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/jazzy-semi-binary-build.yml?branch=master) <br> [![build.ros2.org](https://build.ros2.org/buildStatus/icon?job=Jdev__ros2_controllers__ubuntu_noble_amd64&subject=build.ros2.org)](https://build.ros2.org/job/Jdev__ros2_controllers__ubuntu_noble_amd64/) | [control.ros.org](https://control.ros.org/jazzy/doc/ros2_controllers/doc/controllers_index.html) | [ros2_controllers](https://index.ros.org/p/ros2_controllers/#jazzy)
**Humble** | [`humble`](https://github.com/ros-controls/ros2_controllers/tree/humble) | [![Humble Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/humble-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/humble-binary-build.yml?branch=master) <br> [![Humble Semi-Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/humble-semi-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/humble-semi-binary-build.yml?branch=master) <br> [![build.ros2.org](https://build.ros2.org/buildStatus/icon?job=Hdev__ros2_controllers__ubuntu_jammy_amd64&subject=build.ros2.org)](https://build.ros2.org/job/Hdev__ros2_controllers__ubuntu_jammy_amd64/) | [control.ros.org](https://control.ros.org/humble/doc/ros2_controllers/doc/controllers_index.html) | [ros2_controllers](https://index.ros.org/p/ros2_controllers/#humble)
**Rolling** | [`master`](https://github.com/ros-controls/ros2_controllers/tree/master) | [![Rolling Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-binary-build.yml?branch=master) <br> [![Rolling Semi-Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-semi-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/rolling-semi-binary-build.yml?branch=master) <br> [![build.ros2.org](https://build.ros2.org/buildStatus/icon?job=Rdev__ros2_controllers__ubuntu_noble_amd64&subject=build.ros2.org)](https://build.ros2.org/job/Rdev__ros2_controllers__ubuntu_noble_amd64/) | [control.ros.org](https://control.ros.org/master/doc/ros2_controllers/doc/controllers_index.html) | [![Build Status](https://build.ros2.org/buildStatus/icon?job=Rbin_uN64__ros2_controllers__ubuntu_noble_amd64__binary)](https://build.ros2.org/job/Rbin_uN64__ros2_controllers__ubuntu_noble_amd64__binary/)
**Jazzy** | [`jazzy`](https://github.com/ros-controls/ros2_controllers/tree/jazzy) | [![Jazzy Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/jazzy-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/jazzy-binary-build.yml?branch=master) <br> [![Jazzy Semi-Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/jazzy-semi-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/jazzy-semi-binary-build.yml?branch=master) <br> [![build.ros2.org](https://build.ros2.org/buildStatus/icon?job=Jdev__ros2_controllers__ubuntu_noble_amd64&subject=build.ros2.org)](https://build.ros2.org/job/Jdev__ros2_controllers__ubuntu_noble_amd64/) | [control.ros.org](https://control.ros.org/jazzy/doc/ros2_controllers/doc/controllers_index.html) | [![Build Status](https://build.ros2.org/buildStatus/icon?job=Jbin_uN64__ros2_controllers__ubuntu_noble_amd64__binary)](https://build.ros2.org/job/Jbin_uN64__ros2_controllers__ubuntu_noble_amd64__binary/)
**Humble** | [`humble`](https://github.com/ros-controls/ros2_controllers/tree/humble) | [![Humble Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/humble-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/humble-binary-build.yml?branch=master) <br> [![Humble Semi-Binary Build](https://github.com/ros-controls/ros2_controllers/actions/workflows/humble-semi-binary-build.yml/badge.svg?branch=master)](https://github.com/ros-controls/ros2_controllers/actions/workflows/humble-semi-binary-build.yml?branch=master) <br> [![build.ros2.org](https://build.ros2.org/buildStatus/icon?job=Hdev__ros2_controllers__ubuntu_jammy_amd64&subject=build.ros2.org)](https://build.ros2.org/job/Hdev__ros2_controllers__ubuntu_jammy_amd64/) | [control.ros.org](https://control.ros.org/humble/doc/ros2_controllers/doc/controllers_index.html) | [![Build Status](https://build.ros2.org/buildStatus/icon?job=Hbin_uJ64__ros2_controllers__ubuntu_jammy_amd64__binary)](https://build.ros2.org/job/Hbin_uJ64__ros2_controllers__ubuntu_jammy_amd64__binary/)

## Acknowledgements

Expand Down
22 changes: 2 additions & 20 deletions doc/migration.rst
Original file line number Diff line number Diff line change
@@ -1,23 +1,5 @@
:github_url: https://github.com/ros-controls/ros2_controllers/blob/{REPOS_FILE_BRANCH}/doc/migration.rst

Migration Guides: Iron to Jazzy
Migration Guides: Jazzy to Kilted
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This list summarizes important changes between Iron (previous) and Jazzy (current) releases, where changes to user code might be necessary.


diff_drive_controller
*****************************
* The twist message on ``~/cmd_vel`` is now required to be of stamped type (`#812 <https://github.com/ros-controls/ros2_controllers/pull/812>`_).
* Parameters ``has_velocity_limits``, ``has_acceleration_limits``, and ``has_jerk_limits`` are removed. Instead, set the respective limits to ``.NAN``. (`#1315 <https://github.com/ros-controls/ros2_controllers/pull/1315>`_).

joint_trajectory_controller
*****************************

* Parameter ``allow_nonzero_velocity_at_trajectory_end`` is now per default ``false`` (`#834 <https://github.com/ros-controls/ros2_controllers/pull/834>`_).
* The parameter ``start_with_holding`` is removed, it now always holds the position at activation (`#839 <https://github.com/ros-controls/ros2_controllers/pull/839>`_).
* Goals are now cancelled in ``on_deactivate`` transition (`#962 <https://github.com/ros-controls/ros2_controllers/pull/962>`_).
* Empty trajectory messages are discarded (`#902 <https://github.com/ros-controls/ros2_controllers/pull/902>`_).
* Angle wraparound behavior (continuous joints) was added from the current state to the first segment of the incoming trajectory (`#796 <https://github.com/ros-controls/ros2_controllers/pull/796>`_).
* The URDF is now parsed for continuous joints and angle wraparound is automatically activated now (`#949 <https://github.com/ros-controls/ros2_controllers/pull/949>`_). Remove the ``angle_wraparound`` parameter from the configuration and set continuous joint type in the URDF of the respective joint.
* Tolerances sent with the action goal were not used before, but are now processed and used for the upcoming action. (`#716 <https://github.com/ros-controls/ros2_controllers/pull/716>`_). Adaptions to the action goal might be necessary.
* Parameter ``open_loop_control`` is replaced by ``interpolate_from_desired_state`` and setting the feedback gains to zero (`#1525 <https://github.com/ros-controls/ros2_controllers/pull/1525>`_).
This list summarizes important changes between Jazzy (previous) and Kilted (current) releases, where changes to user code might be necessary.
Loading