Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve antiwindup description (backport #1502) #1503

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 22, 2025

Enhance the antiwindup description to accurately reflect its functionality in control_toolbox code.

control_toolbox/src/pid.cpp::170:173

 if (!gains.antiwindup_) {
    // Limit i_term so that the limit is meaningful in the output
    i_term = std::clamp(i_term, gains.i_min_, gains.i_max_);
  }

This is an automatic backport of pull request #1502 done by [Mergify](https://mergify.com).

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (3e292ba) to head (b13a1dc).
Report is 3 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1503      +/-   ##
==========================================
- Coverage   66.79%   66.77%   -0.02%     
==========================================
  Files         114      114              
  Lines       13409    13409              
  Branches     8289     8290       +1     
==========================================
- Hits         8956     8954       -2     
+ Misses       1440     1434       -6     
- Partials     3013     3021       +8     
Flag Coverage Δ
unittests 66.77% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit 61367a7 into humble Jan 22, 2025
13 of 15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1502 branch January 22, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants