-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use urdf/model.hpp for rolling #1476
Use urdf/model.hpp for rolling #1476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @nakul-py
Please also remove these redundant lines from here :
#include "rclcpp/version.h" | |
#if RCLCPP_VERSION_GTE(29, 0, 0) | |
#include "urdf/model.hpp" | |
#else | |
#include "urdf/model.h" | |
#endif |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1476 +/- ##
==========================================
- Coverage 83.83% 83.81% -0.02%
==========================================
Files 122 122
Lines 11120 11120
Branches 944 943 -1
==========================================
- Hits 9322 9320 -2
- Misses 1489 1491 +2
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hey @saikishor will you also review this pull request #1475 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sure, when I get some time. I'll do it. |
Missed the urdf/model.h include while reviewing
Co-authored-by: Bence Magyar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c602975
Description
urdf/model.h
with conditional includes usingurdf/model.hpp
for Rolling.rclcpp/version.h
.Solve #1473 (review)