Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in steering_controllers_lib (backport #1464) #1466

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 2, 2025

Ackermann is a proper name and should be used as such.


This is an automatic backport of pull request #1464 done by Mergify.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.72%. Comparing base (76ff02c) to head (ab04494).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...g_controller/src/ackermann_steering_controller.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1466   +/-   ##
=======================================
  Coverage   66.72%   66.72%           
=======================================
  Files         113      113           
  Lines       13337    13337           
  Branches     8245     8245           
=======================================
  Hits         8899     8899           
  Misses       1442     1442           
  Partials     2996     2996           
Flag Coverage Δ
unittests 66.72% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller/test/test_ackermann_steering_controller.hpp 81.81% <ø> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 77.77% <ø> (ø)
...llers_library/src/steering_controllers_library.cpp 71.20% <100.00%> (ø)
...library/test/test_steering_controllers_library.hpp 95.65% <ø> (ø)
...troller/test/test_tricycle_steering_controller.hpp 79.79% <ø> (ø)
...g_controller/src/ackermann_steering_controller.cpp 77.14% <0.00%> (ø)

@christophfroehlich christophfroehlich merged commit 66337ce into humble Jan 2, 2025
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1464 branch January 2, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant