-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding use of robot description parameter in the Admittance Controller (backport #1247) #1354
Conversation
#1247) --------- Co-authored-by: Kevin DeMarco <[email protected]> Co-authored-by: Nikola Banovic <[email protected]> Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> (cherry picked from commit 9439764) # Conflicts: # admittance_controller/test/test_admittance_controller.hpp
Cherry-pick of 9439764 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
I'm not sure why the robot_description parameter is not passed to the kinematics interface in the tests. |
I'd advocate for the approach in #1359 . Can make that change in rosdistro too |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## iron #1354 +/- ##
==========================================
- Coverage 65.09% 65.08% -0.01%
==========================================
Files 107 107
Lines 12184 12184
Branches 7494 7495 +1
==========================================
- Hits 7931 7930 -1
- Misses 1534 1540 +6
+ Partials 2719 2714 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
semi-binary builds are fine now!
Replaces #1094.
Adds propagation of
robot_description
through argument to thekinematics_interface
.This is an automatic backport of pull request #1247 done by Mergify.