Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply automatic interface export to ex14 #653

Merged
merged 25 commits into from
Jan 20, 2025
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 24, 2024

Follow-up to #623, needs ros-controls/ros2_control#1885

Base automatically changed from variants to master December 4, 2024 16:44
Copy link
Contributor

mergify bot commented Dec 4, 2024

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich added the hold Wait for a release of upstream packages label Dec 10, 2024
bmagyar
bmagyar previously approved these changes Jan 20, 2025
@christophfroehlich christophfroehlich removed the hold Wait for a release of upstream packages label Jan 20, 2025
@christophfroehlich
Copy link
Contributor Author

Binary builds fail because of missing gz_ros2_control binaries

saikishor
saikishor previously approved these changes Jan 20, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work :)

example_14/hardware/rrbot_sensor_for_position_feedback.cpp Outdated Show resolved Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
@christophfroehlich christophfroehlich dismissed stale reviews from saikishor and bmagyar via ef21eef January 20, 2025 16:23
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@christophfroehlich christophfroehlich changed the title Variants ex14 Apply automatic interface export to ex14 Jan 20, 2025
@christophfroehlich christophfroehlich merged commit d4bd063 into master Jan 20, 2025
8 of 11 checks passed
@christophfroehlich christophfroehlich deleted the variants-ex14 branch January 20, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants