Skip to content

[RM] Isolate start and stop interfaces for each Hardware Component #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

This PR makes sure that the start and stop interfaces in perform_command_mode_switch and prepare_command_mode_switch methods of the Hardware components will receive only the interfaces they expose, instead of all of them as of now.

@saikishor saikishor marked this pull request as draft March 20, 2025 13:01
@saikishor saikishor changed the title Isolate start and stop interfaces for each Hardware Component [RM] Isolate start and stop interfaces for each Hardware Component Mar 20, 2025
@saikishor saikishor marked this pull request as ready for review March 20, 2025 23:09
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (d5c2c99) to head (30846d4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hardware_interface/src/resource_manager.cpp 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
+ Coverage   89.11%   89.14%   +0.03%     
==========================================
  Files         139      139              
  Lines       16116    16146      +30     
  Branches     1389     1392       +3     
==========================================
+ Hits        14362    14394      +32     
  Misses       1224     1224              
+ Partials      530      528       -2     
Flag Coverage Δ
unittests 89.14% <94.87%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/hardware_interface/actuator_interface.hpp 94.11% <ø> (ø)
...ce/include/hardware_interface/system_interface.hpp 86.84% <ø> (ø)
...t/test_resource_manager_prepare_perform_switch.cpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 77.78% <94.87%> (+0.99%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

mergify bot commented Apr 17, 2025

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor force-pushed the isolate/start_stop_interfaces branch from d748f56 to 31c1a1d Compare April 17, 2025 10:44
saikishor and others added 2 commits April 17, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants