-
Notifications
You must be signed in to change notification settings - Fork 337
[RM] Isolate start and stop interfaces for each Hardware Component #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saikishor
wants to merge
10
commits into
ros-controls:master
Choose a base branch
from
pal-robotics-forks:isolate/start_stop_interfaces
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[RM] Isolate start and stop interfaces for each Hardware Component #2120
saikishor
wants to merge
10
commits into
ros-controls:master
from
pal-robotics-forks:isolate/start_stop_interfaces
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2120 +/- ##
==========================================
+ Coverage 89.11% 89.14% +0.03%
==========================================
Files 139 139
Lines 16116 16146 +30
Branches 1389 1392 +3
==========================================
+ Hits 14362 14394 +32
Misses 1224 1224
+ Partials 530 528 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hardware_interface_testing/test/test_resource_manager_prepare_perform_switch.cpp
Outdated
Show resolved
Hide resolved
hardware_interface_testing/test/test_resource_manager_prepare_perform_switch.cpp
Outdated
Show resolved
Hide resolved
hardware_interface_testing/test/test_resource_manager_prepare_perform_switch.cpp
Show resolved
Hide resolved
This pull request is in conflict. Could you fix it @saikishor? |
Co-authored-by: Christoph Fröhlich <[email protected]>
d748f56
to
31c1a1d
Compare
Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich
previously approved these changes
Apr 17, 2025
christophfroehlich
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the start and stop interfaces in
perform_command_mode_switch
andprepare_command_mode_switch
methods of the Hardware components will receive only the interfaces they expose, instead of all of them as of now.