Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoped lock #2045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Wiktor-99
Copy link
Contributor

I looked one more time on the #2011 and I think we should use scoped lock to avoid any potential deadlocks

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (5d4933d) to head (07af756).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
+ Coverage   89.43%   89.46%   +0.03%     
==========================================
  Files         138      138              
  Lines       14794    14792       -2     
  Branches     1271     1271              
==========================================
+ Hits        13231    13234       +3     
+ Misses       1087     1082       -5     
  Partials      476      476              
Flag Coverage Δ
unittests 89.46% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...re_interface/include/hardware_interface/handle.hpp 88.23% <100.00%> (+1.09%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants