-
Notifications
You must be signed in to change notification settings - Fork 337
Fix view_controller_chains #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit fe1d47c.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2026 +/- ##
==========================================
- Coverage 89.34% 89.33% -0.01%
==========================================
Files 132 132
Lines 14688 14686 -2
Branches 1269 1269
==========================================
- Hits 13123 13120 -3
- Misses 1090 1092 +2
+ Partials 475 474 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Thank you so much to fix this. The new graph generated makes way more sense than the previous one 😀 . |
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
This reverts #812 and fixes #1095:
python3-graphviz
IS available as rosdep, and produces the desired output. I don't see the necessity to use pygraphviz, unless someone can fix the code for real.Before (example_16)


After
I also added a
--save
option to save the output as PDF in the current directory instead of viewing it.There is still something wrong in the representation, I'll keep it as draft.