-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Diagnostics] Add diagnostics of execution time and periodicity of the hardware components #2005
base: master
Are you sure you want to change the base?
[Diagnostics] Add diagnostics of execution time and periodicity of the hardware components #2005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some documentation comments at the moment. And is the failing downstream test related?
error: { | ||
type: double, | ||
default_value: 10.0, | ||
description: "The error threshold for the mean error of the hardware component's read/write loop. If the mean error exceeds this threshold, an error diagnostic will be published. This diagnostics will be published only for the asynchronous hardware component, because any affect to the synchronous hardware components will be reflected directly in the controller manager's periodicity.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move some parts of the description to the parameters_context.yaml file, because they are repeating a lot? but I see that it is not sorted correctly in the rst, I'll have a look to fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. Let's get this in as it is consistent with others for now, and let's fix it in a different PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sorting is fixed now with ros-controls/control.ros.org#384
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. I fixed the paramters_context.yaml as you suggested :)
I'm not sure. I'll take a look |
Co-authored-by: Christoph Fröhlich <[email protected]>
This PR aims to add diagnostics to the hardware components regarding their periodicity and execution time.
This PR also fixes the Async HW components runnings at different frequencies and also the periodicity of the main async components that run at mainline frequency
The diagnostics should kinda look like the following screenshots (The following are only to look at the summary):