Support OpenTTD 14 admin interface changes (protocol 3) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For OpenTTD 14.0 support - maybe we should add support for detecting game version and decoding as such? This isn't backwards compatible. Signed-off-by: duck. <[email protected]>
Do this by performing buffer length checking when unmarshalling data. Signed-off-by: duck. <[email protected]>
duckfullstop
added
bug
|
(please let me know if this breaks your implementation!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR better handles cases where data is unexpectedly missing from the incoming packet buffer, most notably in OpenTTD 14 where the company shares have been removed from company update packets.