Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 'spp.' epithet #121

Merged
merged 2 commits into from
Apr 15, 2024
Merged

remove 'spp.' epithet #121

merged 2 commits into from
Apr 15, 2024

Conversation

mattiaghilardi
Copy link
Contributor

This PR closes #120

# remotes::install_github("mattiaghilardi/taxadb", ref = "remove-spp")
taxadb::clean_names(c("Homo sp.", "Homo sp", "Homo sp1", "Homo sps", "Homo spp.", "Homo spp"))
#> [1] "homo" "homo" "homo" "homo" "homo" "homo"

Created on 2024-04-12 with reprex v2.1.0

@cboettig
Copy link
Member

Thanks, looks great. Can you please add yourself as a ctb in the DESCRIPTION, a brief mention of this change in NEWS, and a simple test in tests/?

cboettig
cboettig approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@cboettig cboettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 perfect

@cboettig cboettig merged commit 6c2023d into ropensci:master Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboettig cboettig cboettig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean_names() does not remove 'spp.' epithet
2 participants
@mattiaghilardi @cboettig