Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default branch should not be "master" #863

Merged
merged 5 commits into from
Mar 11, 2025
Merged

default branch should not be "master" #863

merged 5 commits into from
Mar 11, 2025

Conversation

maelle
Copy link
Member

@maelle maelle commented Feb 3, 2025 •
edited
Loading

TODOs

  • Get approval from team 😸 If not, stop.
  • Add Spanish translation
  • Add Portuguese translation (to another PR if necessary)
  • Update changelog

@maelle maelle requested a review from a team February 3, 2025 09:27
@maelle maelle mentioned this pull request Feb 3, 2025
Open
mpadge
mpadge requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't think we should demand that people use "main", but simply that they do not use "master". Happy to discuss if you have other opinions 😄

@maelle @mpadge
Update pkg_building.Rmd
60dee1d 
Co-authored-by: mark padgham <[email protected]>
@maelle
Copy link
Member Author

maelle commented Feb 3, 2025

Right, the default is always easier but not compulsory 😸

@maelle maelle requested a review from a team February 3, 2025 11:07
tdhock
tdhock approved these changes Feb 3, 2025
View reviewed changes
Copy link

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maelle maelle requested a review from yabellini February 25, 2025 13:56
yabellini
yabellini reviewed Feb 25, 2025
View reviewed changes
@mpadge mpadge changed the title make "main" default branch a requirement default branch should not be "master" Feb 26, 2025
@mpadge
Copy link
Member

mpadge commented Feb 26, 2025

@maelle Note that I just renamed the PR, for reasons that I trust are clear here.

@maelle @yabellini
Update pkg_building.es.Rmd
6602583 
Co-authored-by: Yanina Bellini Saibene <[email protected]>
@mpadge mpadge mentioned this pull request Mar 6, 2025
Open
29 tasks
@maelle maelle merged commit 4b6c694 into main Mar 11, 2025
2 checks passed
@mpadge mpadge deleted the master-main branch March 11, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdhock tdhock tdhock approved these changes

@helske helske helske approved these changes

@yabellini yabellini yabellini approved these changes

@mpadge mpadge mpadge approved these changes

Assignees
No one assigned
Labels
content 📃
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maelle @mpadge @tdhock @helske @yabellini