-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GeoJSON #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @sharlagelfand !
I like that you used geojsonio
for obvious reasons, but I wonder since sf
is already used here, if we just use sf instead? I guess it depends on what kind of data you'd want back. Thoughts?
honestly i don't know much about GeoJSON and just googled packages for it -- used ps, i'm working on this package hence my sudden |
sorry for the messy commits 🙈 rebasing is hard |
thanks, looks good. cool about the package (see also #113 and https://github.com/VLucet/rgovcan - also canada) just one change, can you undo the codemeta.json file cahange, so we can keep the PR focused on the actual changes here |
done, thank you! thanks for linking that package too! |
thanks @sharlagelfand |
Adding support for GeoJSON! I think I covered everything (added an example, added geojsonio to suggests, reran codemeta, ran docs, etc). But let me know if I missed anything.
Also, thank you for adding me as an author!☺️