Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for non-ASCII name list fields in toBiblatex and toBibtex #111

Closed
wants to merge 17 commits into from
Closed

Fixes for non-ASCII name list fields in toBiblatex and toBibtex #111

wants to merge 17 commits into from

Commits on Oct 7, 2024

  1. Remove appveyor CI 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    cb77db6 View commit details
    Browse the repository at this point in the history

  2. Avoid msg about page numbers in ReadPDFs for 1page PDFs 

    * Always use pdfinfo to determine number of pages in each PDF in ReadPDFs
even when use.metadata is FALSE
* This avoids a message from pdftotext about incorrect pages
* Refactor test-readPDF.R to make it clearer when tests are skipped
if poppler is not installed

Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d6b70fc View commit details
    Browse the repository at this point in the history

  3. Fix pkg documentation for latest roxygen2 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2d33c38 View commit details
    Browse the repository at this point in the history

  4. Fixes for non-ASCII name list fields in toBiblatex and toBibtex 

    * Add latexify() from dplR instead of tools::encoded_text_to_latex
to improve conversion of non-ASCII characters to valid latex
* Fixes #102, #105, #106

Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    876ccea View commit details
    Browse the repository at this point in the history

  5. Update documentation for latexify author 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2bed4cf View commit details
    Browse the repository at this point in the history

  6. Update GA config for merge queue 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e96a908 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Add sleep to reduce test flakiness 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    82d96c7 View commit details
    Browse the repository at this point in the history

  2. Add website to DESCRIPTION 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    25d0bf8 View commit details
    Browse the repository at this point in the history

  3. Add more retries for flakey test 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    45842ed View commit details
    Browse the repository at this point in the history

  4. Add sleep to each try_again for Pubmed/entrez tests 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7328319 View commit details
    Browse the repository at this point in the history

  5. More retries and sleep time for flaky test 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4a75458 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Check if test order matters for flakiness 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    32742f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Revert change to unit test order 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    992dea9 View commit details
    Browse the repository at this point in the history

  2. Add mock response if PubMed test returns 400 error 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5a2aaf9 View commit details
    Browse the repository at this point in the history

  3. Fix path to data for test in last commit 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b5dfb09 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Always use for one GetPubMedByID test 

    Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    40ccd38 View commit details
    Browse the repository at this point in the history

  2. Use default value for rettype in ReadPubMed 

    * c.f. https://www.ncbi.nlm.nih.gov/books/NBK25499/table/chapter4.T._valid_values_of__retmode_and/

Signed-off-by: Mathew W. McLean <[email protected]>
    @mwmclean
    mwmclean committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6f76ae4 View commit details
    Browse the repository at this point in the history