Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-4296][WFCORE-5406] Tweaks for Windows scripts #1

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

gaol
Copy link

@gaol gaol commented Sep 11, 2023

Some tweaks for Windows:

  • Add ~ for the parameter using in function, like: %~1 for the first parameter, %~2 for the second one, etc, batch script does not use $
  • Replace %PACKAGE_NAME% with !PACKAGE_NAME! in the power shell script

I tested in my local Windows machine, and both standalone.bat and standalone.ps1 can start correctly.

@ropalka ropalka merged commit f980034 into ropalka:WFCORE-4296 Sep 11, 2023
@ropalka
Copy link
Owner

ropalka commented Sep 11, 2023

Thanks @gaol !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants