Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile #952

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Dockerfile #952

wants to merge 1 commit into from

Conversation

santib
Copy link
Member

@santib santib commented Jan 14, 2025 •
edited
Loading

santib
santib commented Jan 14, 2025
View reviewed changes
Dockerfile
@@ -23,7 +23,7 @@ ENV NODE_ENV=production
FROM base AS builder

RUN apt-get update -qq && \
apt-get install -y build-essential libssl-dev libpq-dev git libsasl2-dev curl && \
apt-get install -y build-essential libssl-dev libpq-dev git libsasl2-dev libyaml-dev curl && \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it's needed in both places.

Also, what about Dockerfile.dev ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianPasquale JulianPasquale Awaiting requested review from JulianPasquale

@axelpontetto axelpontetto Awaiting requested review from axelpontetto

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@santib