-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(get): Allow setting a default value on Config::get() #13
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some failing test cases 5244479
Co-Authored-By: Austin Pray <[email protected]>
Discussion: If In my opinion, since we always have a default value ( I vote for something similar to https://github.com/laravel/framework/blob/4a74d20f8d960b38d75dd525946e893c75a94dbc/src/Illuminate/Config/Repository.php#L33-L58 But, see Line 127 in 629c533
|
No description provided.