Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_file() deprecation warning #340

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix is_file() deprecation warning #340

merged 1 commit into from
Feb 2, 2024

Conversation

joshuafredrickson
Copy link
Contributor

Using Sage on vanilla WP, you'll receive the following notice due to Filesystem::closest returning null because there's no .env to be found.

Deprecated: is_file(): Passing null to parameter #1 ($filename) of type string is deprecated in /vendor/roots/acorn/src/Roots/Acorn/Bootloader.php on line 376

retlehs
retlehs approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@retlehs retlehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This also happens on any environment that doesn't use an .env file even on Bedrock installs, like when using Lando

@retlehs retlehs merged commit 4a26ed7 into roots:main Feb 2, 2024
2 checks passed
@joshuafredrickson joshuafredrickson deleted the patch-1 branch February 2, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retlehs retlehs retlehs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuafredrickson @retlehs