Fix a missing include. #930
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an unknown reason, cling managed to compile a test that's missing an include directive. The include is added here, since it provoked a failure in a branch that's still WIP.
|
Starting build on |
guitargeek
approved these changes
Dec 27, 2022
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Warnings:
And 130 more Failing tests:
|
|
Build failed on ROOT-ubuntu2004/python3. Warnings:
And 54 more Failing tests:
|
|
Build failed on mac11/cxx14. Warnings:
And 54 more Failing tests:
|
|
Build failed on mac12/noimt. Warnings:
And 53 more Failing tests:
|
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
And 60 more Failing tests:
|
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests: |
|
That should be autoloaded, I believe? It's not compiled but interpreted, so autoloading is part of the game. |
|
Build failed on mac12/noimt. Failing tests: |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Failing tests: |
|
Build failed on windows10/cxx14. Failing tests: |
|
Build failed on mac11/cxx14. Failing tests: |
|
@phsft-bot build |
|
Starting build on |
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
Build failed on mac12/noimt. Failing tests: |
|
All the error seems to be due to a 'missing' rebase of roottest and are unrelated to the change here. |
|
@lmoneta somehow this was left unmerged. Could you make sure the change still work and merge at your convenience? |
|
@dpiparo note Axel's comment:
My understanding is that adding the include might hide a problem in autoloading provoked / visible by Stephan's branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an unknown reason, cling managed to compile a test that's missing an include directive. The include is added here, since it provoked a failure in a branch that's still WIP.