Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tree] test for limits in buildindex #1090

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[tree] test for limits in buildindex #1090

wants to merge 7 commits into from

Conversation

ferdymercury
Copy link
Contributor

No description provided.

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@ferdymercury
Copy link
Contributor Author

matches root-project/root#14967

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

1 similar comment
@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

vepadulano
vepadulano previously requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some questions regarding the implementation of the test

root/tree/index/runindex64.C Outdated Show resolved Hide resolved
root/tree/index/runindex64.C Outdated Show resolved Hide resolved
root/tree/index/runindex64.C Outdated Show resolved Hide resolved
root/tree/index/runindex64.C Outdated Show resolved Hide resolved
root/tree/index/runindex64.C Outdated Show resolved Hide resolved
root/tree/index/runindex64.C Outdated Show resolved Hide resolved
root/tree/index/runindex64.C Outdated Show resolved Hide resolved
root/tree/index/runindex64.C Outdated Show resolved Hide resolved
root/tree/index/runindex64.C Outdated Show resolved Hide resolved
pcanal
pcanal requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

1 similar comment
@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@ferdymercury ferdymercury dismissed stale reviews from pcanal and vepadulano April 17, 2024 09:39

Changes done

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T09:48:01.235Z] /home/sftnight/build/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T09:53:46.429Z] /data/sftnight/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@ferdymercury
[tree] test for limits in buildindex
e1267e8
@ferdymercury
deactivate different limits for platforms
15e008b 
as it gives problems with the Error output of GetIndex when comparing with the .ref

clarify wording

and restore platform-dependency

no need for minor/major limits
@ferdymercury
only print Scan if test fails
86e35b6 
apply pcanals suggestion
@ferdymercury
only print event entries if error
a2753bb
@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T10:39:58.741Z] /home/sftnight/build/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T10:45:55.183Z] /data/sftnight/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T10:36:00.394Z] /home/sftnight/build/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@ferdymercury
simulate previous behavior
10f306d 
which was wrongly casting 64bit to 32bit
@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T11:28:43.831Z] /home/sftnight/build/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T11:34:16.604Z] /data/sftnight/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T11:25:16.134Z] /home/sftnight/build/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@phsft-bot
Copy link

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T13:11:07.496Z] /data/sftnight/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T13:13:20.680Z] /home/sftnight/build/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

@phsft-bot
Copy link

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2024-04-17T13:31:28.341Z] /home/sftnight/build/workspace/roottest-pullrequests-build/root/graf2d/gpad/src/TPad.cxx:587:22: warning: declaration of ‘obj’ shadows a previous local [-Wshadow]

Failing tests:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepadulano vepadulano Awaiting requested review from vepadulano

@pcanal pcanal Awaiting requested review from pcanal

At least 1 approving review is required to merge this pull request.

Assignees

@pcanal pcanal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ferdymercury @phsft-bot @pcanal @vepadulano