Skip to content

[gpad] TPad fix clang-tidy warnings #18494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

ferdymercury
Copy link
Contributor

This Pull request:

Changes or fixes:

applies fixes to clang-tidy diagnostics in class TPad

@ferdymercury ferdymercury requested a review from linev April 24, 2025 14:37
@ferdymercury ferdymercury requested a review from couet as a code owner April 24, 2025 14:37
linev
linev previously requested changes Apr 24, 2025
Copy link
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer not to change code of TPad::PaintHatches

Copy link

github-actions bot commented Apr 25, 2025

Test Results

    18 files      18 suites   3d 21h 28m 24s ⏱️
 2 731 tests  2 730 ✅ 0 💤 1 ❌
47 716 runs  47 715 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit c7da3b5.

♻️ This comment has been updated with latest results.

found out by clang-tidy
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@guitargeek guitargeek merged commit f0acaa3 into root-project:master Apr 29, 2025
19 of 22 checks passed
@ferdymercury ferdymercury deleted the padtidy branch April 29, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants