-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Testing code coverage workflow #18469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pcanal
wants to merge
38
commits into
root-project:v6-36-00-patches
Choose a base branch
from
pcanal:code_coverage
base: v6-36-00-patches
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+199
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe related: #18392 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v6-36-00-patches #18469 +/- ##
===================================================
Coverage ? 8.07%
===================================================
Files ? 3696
Lines ? 560962
Branches ? 258185
===================================================
Hits ? 45275
Misses ? 483913
Partials ? 31774
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
34c3923
to
7972f79
Compare
The CMake issue: https://gitlab.kitware.com/cmake/cmake/-/issues/23040 leads to spurrious differences in the Ninja and CMake files related to pdb vs dbg files.
For consistency LLVM adds the 'D' flag to ar for building static to ensure that they have a deterministic build. However the setting is done too late/too nested and during the first configuration run, it is not applied to some libraries (plugins, Cling). Consequently, after a 2nd configuration run they need to be rebuild. This commit moves/duplicates the setting sooner.
Solve the warning: .../core/meta/src/TClass.cxx: In member function 'virtual void TDumpMembers::Inspect(TClass*, const char*, const char*, const void*, Bool_t)': .../core/meta/src/TClass.cxx:770:20: warning: 'char* strncpy(char*, const char*, size_t)' specified bound 994 equals destination size [-Wstringop-truncation] 770 | strncpy(line + kvalue, *ppointer, kline - kvalue); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Filter out non-option cache variable about the project and CMake version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #